Draft
Conversation
runer112
reviewed
Apr 5, 2026
| pop de | ||
| pop de | ||
| pop de | ||
| ld sp, ix |
Member
There was a problem hiding this comment.
This wouldn't exactly a peephole optimization, but you could entirely remove this.
Suggested change
| ld sp, ix |
| call usb_GetDeviceEndpoint | ||
| pop de | ||
| pop de | ||
| ld sp, ix |
Member
There was a problem hiding this comment.
This wouldn't exactly a peephole optimization, but you could entirely remove this.
Suggested change
| ld sp, ix |
Contributor
Author
There was a problem hiding this comment.
I realized we can also call .line_coding here to save another byte
Contributor
Author
There was a problem hiding this comment.
Although to be fair. If we need to save bytes we would just rewrite that whole function in assembly lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collection of unrelated assembly peephole optimizations